[PoC]of attribute ref renaming #277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisch-me
reviewed
Aug 1, 2024
| } => { | ||
| let name; | ||
| let root_attr = self.root_attributes.get(r#ref); | ||
| if let Some(root_attr) = root_attr { | ||
| let mut attr_lineage = AttributeLineage::new(&root_attr.group_id); | ||
|
|
||
| if *prefix { |
There was a problem hiding this comment.
fyi: prefix means that attribute will be embedded i.e. having parent prefix in his name
|
@MadVikingGod or @trisch-me - Are we entertaining this PoC anymore or should we close this PR as stale at this point? |
|
As I mentioned during one of the meetings we already have working As we are moving slowly forward with embed I propose to implement everything there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept on the viability of using renaming of attributes to duplicate the functionality of attribute embedding in open-telemetry/semantic-conventions#1264
This adds another field to the ref attributes that allows you to rename the attribute. This lets you import multiple copies of the same reference into an attribute group. as demonstrated in the test.
This is a Proof of Concept please don't merge.